[1.1.x] Simplify mesh bounds config #8043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
bf1_mesh_consolidate
branch
3 times, most recently
from
3278515
to
505557a
Compare
thinkyhead
changed the title
thinkyhead
force-pushed
the
bf1_mesh_consolidate
branch
2 times, most recently
from
8572bc5
to
22a3349
Compare
thinkyhead
force-pushed
the
bf1_mesh_consolidate
branch
from
c22c2cd
to
f06f4b4
Compare
|
This is a good thing getting everybody to a common name. I just hope it goes smoother than the X_BED_SIZE change. That broke a lot of stuff, especially with Delta's. |
This adds no new options, so should be less disruptive. |
kForth
pushed a commit
to kForth/Marlin
that referenced
this pull request
Jun 22, 2022
…lidate [1.1.x] Simplify mesh bounds config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default mesh bounds are based on mesh inset and bed size, with constraints applied based on physical bounds and probe offset. Only override if needed.
To simplify conditionals
UBL_MESH_INSETis renamedMESH_INSETandUBL_MESH_(MIN|MAX)_[XY]can also drop theUBL_prefix.The conditional aspects of these settings need to move to Conditionals, as they already use
IS_SCARAand other things not permitted inConfiguration_adv.hanyway. The idea is that these settings can be left totally unset unless there's some pressing need to set them. And the default overrides are simple bed-size based. Craftier users may borrow elements ofConditionals_post.h.For 1.1.x increment the configuration version numbers to "encourage" users to re-examine their configuration files.