Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1] Add Anet Keypad LCD pins for RAMPS #8243

Merged

Conversation

Augustus22
Copy link

Working pin map for Anet LCD display.
Pins 1 and 2 must be swapped on cable.

@thinkyhead
Copy link
Member

thinkyhead commented Nov 3, 2017

Please put this into Conditionals_LCD.h in the appropriate place…

#elif ENABLED(ANET_KEYPAD_LCD)
  #define ENCODER_FEEDRATE_DEADZONE 2
#endif

@thinkyhead thinkyhead changed the title Added support for Anet LCD on Ramps board. [1.1] Add Anet Keypad LCD pins for RAMPS Nov 3, 2017
@Augustus22
Copy link
Author

I only put it in pins_RAMPS.h because it was defined in pins_ANET_10.h. Would you like me to remove it from both of those locations and put it in Conditionals_LCD.h instead?

@thinkyhead
Copy link
Member

Would you like me to remove it from both of those locations and put it in Conditionals_LCD.h instead?

Yes, thanks. That's the appropriate place for these kinds of non-pin settings.

@Augustus22
Copy link
Author

Sorry about the merge. I should have rebased first. I assume you squash commits?

@thinkyhead
Copy link
Member

Sorry about the merge. I should have rebased first. I assume you squash commits?

Not a problem. If things get really out of whack, there's always git diff!

Working pin map for Anet LCD display.
Pins 1 and 2 must be swapped on cable.
@thinkyhead thinkyhead merged commit 4388719 into MarlinFirmware:bugfix-1.1.x Nov 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants