Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for RAMPS 1.4 Plus board #8655

Merged
merged 1 commit into from Dec 5, 2017

Conversation

kein0r
Copy link

@kein0r kein0r commented Dec 4, 2017

Based on the information I found in the internet, pull-request #5332 and the information provided by the supplier of my printer I added support for RAMPS 1.4 Plus board.

The board differs from the original RAMPS 1.4 board in the following ways:

  • Pins for heater E0 with E1 are swapped
  • Pins 8 and 10, which control fan and hotbed are swapped
  • Pins that control the display are changed in the following way 16 -> 42, 17 -> 44 and 29 -> 53

Instead of adding the changes to pins_RAMPS.h I decided to copy the file and adding the changes to a separate file. This way

  1. I do not break anything
  2. The file won't get too complicated to read with several layers of #ifdef in it

I tested it on my printer using BOARD_RAMPS_14P_EFB and REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER and can confirm that it's working

@thinkyhead
Copy link
Member

thinkyhead commented Dec 4, 2017

Hi @kein0r — Thanks for the contrib!

Instead of adding the changes to pins_RAMPS.h I decided to copy the file and adding the changes to a separate file.

I've reduced the pins file down to just the bare minimum needed to apply differences to the RAMPS 1.4 standard pins. It should make the pins file a lot easier to maintain!

I will package this up for 2.0.x also and merge shortly.

Conflicts:
	Marlin/boards.h
@thinkyhead thinkyhead merged commit 88b34d2 into MarlinFirmware:bugfix-1.1.x Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants