Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1] Fix FILAMENT_LCD_DISPLAY, disabled state, optimize #8459

Merged
merged 1 commit into from Nov 16, 2017

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Nov 16, 2017

Addressing #8453, companion to #8455

The Filament Width LCD display shows "125%" when volumetric is turned off. And it displays the volumetric_multiplier incorrectly, as if it were a percentage related to the filament width.

This PR fixes the LCD display code to show the simple ratio between the Nominal Filament Width (as set by M404 W[width]) and the measured filament width (as determined by a Filament Width Sensor, or as set directly by M200 D[width]). When volumetric mode is disabled it will display ---.

Also applies the filament width display optimization to both SDSUPPORT and non-SDSUPPORT display modes.

@Grogyan
Copy link
Contributor

Grogyan commented Nov 16, 2017

Does this fix also allow for multi materials?
Just asking as the line you changed was for an array , now set to a single material.

@thinkyhead
Copy link
Member Author

The filament width sensor is only supported for a single extruder currently. If using multiple extruders with different nominal widths (3.0 vs 2.85 vs 1.75) passing through a single filament width sensor, add M404 W after tool change to specify the expected (nominal) width.

@thinkyhead thinkyhead merged commit 3dee106 into MarlinFirmware:bugfix-1.1.x Nov 16, 2017
@thinkyhead thinkyhead deleted the bf1_filwidth_fix branch November 16, 2017 23:58
@Grogyan
Copy link
Contributor

Grogyan commented Nov 17, 2017

I was meaning for each material with it's own filament sensor. Each then gets fed into a single/multiple extruders

@thinkyhead
Copy link
Member Author

Marlin only supports a single Filament Width Sensor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants