[1.1.x] SERIAL_XON_XOFF not supported on USB-native AVR devices #8653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiveangle
force-pushed
the
bf1_usbcon_xonxoff
branch
3 times, most recently
from
d4d0a47
to
2ba79a6
Compare
User could enable SERIAL_XON_XOFF on USB-native devices and it would not be enabled without warning, but M115 would report the capability as available.
fiveangle
force-pushed
the
bf1_usbcon_xonxoff
branch
from
2ba79a6
to
406f665
Compare
fiveangle
commented
Dec 4, 2017
|
|
||
| #ifndef USBCON |
There was a problem hiding this comment.
My biggest question is why all these tests can't be run even if USBCON is defined ? But it's 1.1.x so I'm not going to lose any sleep over it ;)
There was a problem hiding this comment.
It looks like we're assuming those options can't be overridden on platforms that have USBCON. I'd have to reach back into the Git Blame annals to find out the reasoning.
mtm88001
pushed a commit
to mtm88001/Marlin
that referenced
this pull request
Dec 9, 2017
…inFirmware#8653) * SERIAL_XON_XOFF not supported on USB-native AVR devices User could enable SERIAL_XON_XOFF on USB-native devices and it would not be enabled without warning, but M115 would report the capability as available.
damicreabox
pushed a commit
to damicreabox/Marlin
that referenced
this pull request
Sep 14, 2018
…inFirmware#8653) * SERIAL_XON_XOFF not supported on USB-native AVR devices User could enable SERIAL_XON_XOFF on USB-native devices and it would not be enabled without warning, but M115 would report the capability as available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User could enable SERIAL_XON_XOFF on USB-native devices and it would not be enabled without warning, but M115 would report the capability as available.
@thinkyhead - can you please review this one as I may have made some incorrect assumptions when porting this fix from bugfix2.0.x where there were some changes in this area. I tried relocating the sanity checks from within
MarlinSerial.hbut it would break non-USB AVR, and vice versa (which is why I believe you may have left them there in the first place ?)'Spent way too long messing with this 1.1.x port. I tested all error conditions and confirms it works as expected, but you should take a quick once over just in case it could be done better (note the relocation of USBCON check below the setting of the default buffers sizes to pick those up for both, while USBCON is taken care of in Conditionals_adv.h in bf2).
I think this just further illustrates the need to release 2.0 + 1.1.7 and leave 1.1.7 to strict bugfix-only ;)