[1.1.x] Fix PlatformIO dependencies #8452
Conversation
|
I believe PIO doesn't differentiate between |
platformio.ini
Outdated
| lib_deps = | ||
| U8glib@1.19.1 | ||
| https://github.com/lincomatic/LiquidTWI2.git | ||
| https://github.com/teemuatlut/TMC2130Stepper.git |
There was a problem hiding this comment.
Please use the library name and not git links. In the TMC SPI discussion it was discovered that PIO doesn't play nice with direct links.
There was a problem hiding this comment.
This approach seemed to be working without issue and is the same as in bugfix-2.0.x. I'd suggest we change it there if we're going to change it here.
There was a problem hiding this comment.
Yea the problem was with the LPC HAL and didn't link properly. It was fine for Teensy and AVR (possibly) so you wouldn't see a problem v1.1.x. It needs to be changed with v2.0 but I haven't bothered with it yet and it might just get included in some other PR.
There was a problem hiding this comment.
The LiquidTWI2 and TMC26XStepper libraries don't appear to be in the PlatformIO Library Manager, so I had to keep the git links for those. I was able to switch to using the library names for the others.
tcm0116
force-pushed
the
1.1.x-pio_deps
branch
from
bff27cb
to
97c19de
Compare
It turns out that the HFS+ file system on my Mac is actually case-insensitive and it appears that the AVR compiler used by PlatformIO doesn't distinguish between |
|
@tcm0116 I've also run into case-insensitivity issues in git / macOS / HFS+ when I rename something, only changing its case. One of those little annoyances. Fortunately, when you use the Unix command-line, everything works in a case-sensitive fashion. |
|
Looks like the |
The PlatformIO configuration for 1.1.x was missing most of the library dependencies, so options such as the TMC2130 drivers wouldn't compile.
Additionally, there was a strange issue where PlatformIO was trying to compile the TMC2130 library using spi.h from within the Marlin code, even though the library was including SPI.h from the Arduino framework. I'm not really sure why the case sensitivity was an issue (especially on my Mac), but the easiest solution was to rename Marlin/spi.h to Marlin/MarlinSPI.h and fix the include in temperature.cpp.
One dependency that I didn't add is Arduino-L6470 as it doesn't even appear to compile correctly in the Arduino IDE due to stepper_indirection.cpp attempting to call
L6470::init()with a parameter even though the function does not accept a parameter. I checked the history of the library, and it doesn't appear that the function ever accepted a parameter. I'm not sure how that ever worked.