[1.1.x] Fix NO_MOTION_BEFORE_HOMING unwanted behaviour #8177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NO_MOTION_BEFORE_HOMING should prevent XYZ movements only when homing is not done. E axes should be allowed
GMagician
commented
Oct 31, 2017
There was a problem hiding this comment.
@thinkyhead that's not the solution I intended to realize.
Option should prevent moving XYZ when they are not all homed. With your solution once one of them is homed it can be moved!
MoellerDi
added a commit
to MoellerDi/Marlin
that referenced
this pull request
Nov 27, 2017
… into bugfix-1.1.x-HD-CR10 * 'bugfix-1.1.x' of https://github.com/MarlinFirmware/Marlin: Only show custom bootscreen once [1.1.x] Fix NO_MOTION_BEFORE_HOMING unwanted behaviour (MarlinFirmware#8177) Kinematic clamp_to_software_endstops Fix for MAX_VFAT_ENTRIES sanity check The plural of 'axis' is 'axes' Tweak to QUICK_HOME comment No hacks needed for SD_REPRINT_LAST_SELECTED_FILE Tweak for soft endstops Update LCD draw condition Cleanups for SD_REPRINT_LAST_SELECTED_FILE Include time scale in some planner vars Add a hidden 8s watchdog option for easier debugging Add mfup to mfpub for safety Provide a default SERVO0_PIN for Anet 1.0 Followup to MarlinFirmware#8123 - to match 2.0.x changes # Conflicts: # Marlin/Configuration_adv.h
mtm88001
pushed a commit
to mtm88001/Marlin
that referenced
this pull request
Dec 9, 2017
…e#8177) * [1.1.x] Fix NO_MOTION_BEFORE_HOMING unwanted behaviour NO_MOTION_BEFORE_HOMING should prevent XYZ movements only when homing is not done. E axes should be allowed * Update Marlin_main.cpp * Update Marlin_main.cpp * Update Marlin_main.cpp
damicreabox
pushed a commit
to damicreabox/Marlin
that referenced
this pull request
Sep 14, 2018
…e#8177) * [1.1.x] Fix NO_MOTION_BEFORE_HOMING unwanted behaviour NO_MOTION_BEFORE_HOMING should prevent XYZ movements only when homing is not done. E axes should be allowed * Update Marlin_main.cpp * Update Marlin_main.cpp * Update Marlin_main.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NO_MOTION_BEFORE_HOMING should prevent XYZ movements only when homing is not done.
E axes should be allowed