[1.1.x] Add M73 (LCD_SET_PROGRESS_MANUALLY) #7986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
thinkyhead
force-pushed
the
bf1_progress_percentage
branch
2 times, most recently
from
2393c82
to
8a1d892
Compare
thinkyhead
force-pushed
the
bf1_progress_percentage
branch
from
8a1d892
to
5f708d4
Compare
|
Thanks, I had no idea there was that much additional code to be added, I'm glad the snippet i provided helped. |
|
Thanks for the contrib, @SydneyMakers. It looks like we'll also be adding support for the G-code |
|
Just for further reference, if I am implementing gcode commands based on Issues in this github, what are the things to note regarding functions, defining features, and documentation? |
kForth
pushed a commit
to kForth/Marlin
that referenced
this pull request
Jun 22, 2022
…ercentage [1.1.x] Add M73 (LCD_SET_PROGRESS_MANUALLY)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #7953… Demonstrating how to implement #6451 as an optional feature.
In the category of Print Job Support, this feature has been on our TODO list for awhile.
Add the
M73G-code to set the current progress percentage, which will update the progress bar on the LCD. Note that this has no effect during SD card printing.