[1.1.x] Split first move to planner for better chaining #8658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
backup_1_split_first
branch
from
ce1e570
to
000818f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the first move to an empty planner to allow chaining subsequent moves. This fixes a longstanding issue in Marlin (and Grbl) where the first move starts to get processed by the Stepper ISR before the planner has had a chance to chain its velocity to the next move.
Thanks to @AnHardt for proposing this solution!
Thanks to @hg42 for solving a vexing issue! Arrays must be passed by reference or the
sizeof(myarray)information gets lost.References: #8573, #8595