[1.1.x] Update Thermal Protection Documentation #8282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even before the recent thermal protection changes, the documentation of the thermal protection feature in the config files did not match the implementation. I fixed the documentation and reconciled the M303 implementation with the documentation.
RowanMeara
changed the title
thinkyhead
reviewed
Nov 7, 2017
| * | ||
| * If you get too many "Heating failed" errors, increase WATCH_BED_TEMP_PERIOD and/or decrease | ||
| * WATCH_BED_TEMP_INCREASE. (WATCH_BED_TEMP_INCREASE should not be below 2.) | ||
| * As described above, except for the bed. |
There was a problem hiding this comment.
Perhaps this should continue to include the references to M140/M190, as these bed and hotend temperature G-codes are easy to get mixed up.
There was a problem hiding this comment.
Okay, that makes sense. I put the gcodes back in without the repeated explanation.
thinkyhead
reviewed
Nov 7, 2017
| #else | ||
| TEMP_HYSTERESIS | ||
| WATCH_TEMP_INCREASE |
There was a problem hiding this comment.
The hysteresis is the range of temperature considered close enough to call the temperature a match. If the hysteresis variable is being used in some other way, then it shouldn't be called hysteresis.
There was a problem hiding this comment.
Yeah, I noticed that last night. I'll make that change.
mtm88001
pushed a commit
to mtm88001/Marlin
that referenced
this pull request
Dec 9, 2017
* Fix thermal protection documentation. Even before the recent thermal protection changes, the documentation of the thermal protection feature in the config files did not match the implementation. I fixed the documentation and reconciled the M303 implementation with the documentation. * Applied documentation changes to sample config files * Renamed hysteresis to watch_temp_increase * Added gcodes back into documentation.
damicreabox
pushed a commit
to damicreabox/Marlin
that referenced
this pull request
Sep 14, 2018
* Fix thermal protection documentation. Even before the recent thermal protection changes, the documentation of the thermal protection feature in the config files did not match the implementation. I fixed the documentation and reconciled the M303 implementation with the documentation. * Applied documentation changes to sample config files * Renamed hysteresis to watch_temp_increase * Added gcodes back into documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even before the recent M303 thermal protection changes, the documentation of
the thermal protection feature in the config files did not match the
implementation. I fixed the documentation and reconciled the M303
implementation with the documentation.
The documentation stated that thermal protection needed to be enabled to have min and max temp protection. However, the thermal protection feature does not affect min/max temperature protection so I corrected the documentation.
The Configuration_adv.h has two pairs of thermal timeout variables for different scenarios. I updated the M303 thermal protection in temperature.cpp to use the correct variable pair.