Initialize mixing virtual tools to behave like standard a multi-extruder setup #6853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The default may seem unusual, but I think it makes sense that until you have set one or more mixes and determined that you will in fact be loading and using more than 1 filament, then any tool-changes should be essentially ignored and continue to use only the first filament. |
|
Are there any mixing extruders that don't require all of the filaments to
be loaded? The only one I know of is the Diamond, and bad things will
happen if you only have one filament loaded.
The reason I did this is because I was playing around with using the mixing
extruder configuration for my Cyclops, which is actually a switching hotend
(two feeders with one nozzle), but since the filament paths meet in the
heater block, it can sort of be used to mix. As such, I found it odd that
by default, it didn't feed the second filament when I selected T1.
I would think that a switching hotend could be thought of as a special type
of mixing hotend. As such, it seems to me that it would make sense if they
functioned the same until virtual tools are configured.
|
thinkyhead
force-pushed
the
bugfix-1.1.x
branch
from
bb58d68
to
524f4ee
Compare
thinkyhead
force-pushed
the
bugfix-1.1.x
branch
2 times, most recently
from
54081a8
to
4e19c59
Compare
|
Sold! Will merge soon…. |
MoellerDi
added a commit
to MoellerDi/Marlin
that referenced
this pull request
Nov 27, 2017
… into bugfix-1.1.x-HD-CR10 * 'bugfix-1.1.x' of https://github.com/MarlinFirmware/Marlin: (27 commits) SD Menu patches Tweaks to bed leveling menus Adjustments to blocking moves M211 output in current workspace Loosen HAS_BED_PROBE definition Parity with 2.0.x bitmap functions Fix gcode_G26 error return Fix Micromake C1 config Syntax tweaks Move BABYSTEP_ZPROBE_GFX_OVERLAY up M290 report on change, P0 to leave Probe Z Offset unchanged Followup to G33 patch [1.1.x] G33 probe error handing Patches for M290, M851 Dont use Z_MIN_PROBE_ENDSTOP for DELTA Initialize mixing virtual tools to behave like standard a multi-extruder setup (MarlinFirmware#6853) Apply LINEAR_UNIT to M503 output for M200 Fix MarlinFirmware#8540 MK2_MULTIPLEXER does not require E2/E3 stepper pins Fix MarlinFirmware#8537 ...
mtm88001
pushed a commit
to mtm88001/Marlin
that referenced
this pull request
Dec 9, 2017
…der setup (MarlinFirmware#6853) * Initialize mixing virtual tools to behave like standard a multi-extruder setup * Update Marlin_main.cpp * Update Marlin_main.cpp
damicreabox
pushed a commit
to damicreabox/Marlin
that referenced
this pull request
Sep 14, 2018
…der setup (MarlinFirmware#6853) * Initialize mixing virtual tools to behave like standard a multi-extruder setup * Update Marlin_main.cpp * Update Marlin_main.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To me, it seems odd that selecting any tool with
MIXING_EXTRUDERenabled would only utilize color Number 1. As such, this PR initializes the virtual tools such that:MIXING_EXTRUDERwill be 100% color # 1