[1.1.x] Fix EEPROM CRC #8283
Merged
[1.1.x] Fix EEPROM CRC #8283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix EEPROM reversion.
Merged
|
I verified this fixes the EEPROM CRC issue for bugfix-v1.1.x |
thinkyhead
reviewed
Nov 7, 2017
| @@ -1088,7 +1088,7 @@ void MarlinSettings::postprocess() { | |||
| stepperE4.setCurrent(val, R_SENSE, HOLD_MULTIPLIER); | |||
| #endif | |||
| #else | |||
| for (uint8_t q = 11; --q;) EEPROM_READ(val); | |||
| for (uint8_t q = 0; q < 11; q++) EEPROM_READ(val); | |||
There was a problem hiding this comment.
This doesn't change the "read order," ya know.
The only issue was that it should've been q-- instead of --q to get the correct number of items.
There was a problem hiding this comment.
Yes... And that is why I reverted #8284. I didn't test the bugfix-v2.0.0 branch, but it looked like it was OK.
There was a problem hiding this comment.
Oh duh... I'm smart... sorry guys.
mtm88001
pushed a commit
to mtm88001/Marlin
that referenced
this pull request
Dec 9, 2017
Fix EEPROM reversion.
damicreabox
pushed a commit
to damicreabox/Marlin
that referenced
this pull request
Sep 14, 2018
Fix EEPROM reversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the order in which the EEPROM is read changes the CRC. e642a64 changed the EEPROM read order without changing the write order. I reverted the problematic line so that I can read from the EEPROM again.