Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.1.x] Fix up LCD init / charset #8526

Merged
merged 2 commits into from Nov 23, 2017
Merged

[1.1.x] Fix up LCD init / charset #8526

merged 2 commits into from Nov 23, 2017

Conversation

thinkyhead
Copy link
Member

Addressing #8509

No need to call lcd_init after boot-screen if the lcd_bootscreen manages resetting the custom characters.

@thinkyhead thinkyhead force-pushed the bf1_lcd_init_charset branch 4 times, most recently from b6a5db9 to a19d911 Compare November 23, 2017 00:04
@AnHardt
Copy link
Member

AnHardt commented Nov 23, 2017

Just to break my series.
This is looking very nice.

@thinkyhead
Move lcd_map_control to UBL
99b71c1 
For parity with bugfix-2.0.x
@thinkyhead thinkyhead mentioned this pull request Nov 23, 2017
Merged
@thinkyhead
Copy link
Member Author

Consolidating custom character code should make it easier to add new custom characters in future.

@thinkyhead thinkyhead merged commit 3958ff8 into MarlinFirmware:bugfix-1.1.x Nov 23, 2017
@thinkyhead thinkyhead deleted the bf1_lcd_init_charset branch November 23, 2017 00:58
@riverratdc riverratdc mentioned this pull request Feb 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: LCD & Controllers PR: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thinkyhead @AnHardt