[1.1.x] Simplify SD_REPRINT_LAST_SELECTED_FILE #8160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
bf1_fixup_sd_reprint
branch
from
f680427
to
3333517
Compare
thinkyhead
force-pushed
the
bf1_fixup_sd_reprint
branch
4 times, most recently
from
8055850
to
383b9db
Compare
thinkyhead
force-pushed
the
bf1_fixup_sd_reprint
branch
from
383b9db
to
5e5a177
Compare
|
The Graphical LCD Panel is behaving a lot better. But it still messes up the select lines around an SD-File. Some times, only one line appears. And it seems to be random whether it is the top or bottom select line. Update: I have also seen it leave select lines such that 3 files are selected (with top and bottom lines around them). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup patch for #8098. Parity with #8113.
As a general rule, if you find yourself hacking core code or being too clever, you're probably doing it wrong. In most cases there is one right way to do things. Ask @thinkyhead for help if you find yourself cursing Marlin for not doing what you want.
defer_return_to_status" works as designed, so no need to hack it.Compliments earlier changes in compliance with good coding practices:
externreferences fromcardreader.cpp, moving all that code to thelcd_reselect_last_filefunction, which is externally exposed inultralcd.h. This represents the best-practice of "encapsulation."Still to do:
lcd_reselect_last_fileto determine the minimum required "bump" needed to get a complete graphical screen redraw when jumping to the SD menu.