[1.1.x] Add MKS MINI 12864 support to GT2560 #8048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madmo
commented
Oct 21, 2017
madmo
commented
- Add pin configurations to pins_GT2560_REV_A for MKS MINI 12864
- Update sample configuration to enable SDSUPPORT if MKS_MINI_12864 is selected
thinkyhead
reviewed
Oct 25, 2017
| @@ -1735,7 +1735,7 @@ | |||
| /** | |||
| * Customize common displays for GT2560 | |||
| */ | |||
| #if ENABLED(ULTIMAKERCONTROLLER) || ENABLED(REPRAP_DISCOUNT_SMART_CONTROLLER) || ENABLED(G3D_PANEL) | |||
| #if ENABLED(ULTIMAKERCONTROLLER) || ENABLED(REPRAP_DISCOUNT_SMART_CONTROLLER) || ENABLED(G3D_PANEL) || ENABLED(MKS_MINI_12864) | |||
| #define SDSUPPORT // Force SD Card support on for these displays | |||
There was a problem hiding this comment.
Note that this makes it harder for users to disable SDSUPPORT for debugging, which was the intent of having it as a separate option, disabled by default. In the long run, we may set a flag for displays that have SD built-in and throw out a warning to users who forget to enable SDSUPPORT on those displays.
thinkyhead
changed the title
kForth
pushed a commit
to kForth/Marlin
that referenced
this pull request
Jun 22, 2022
[1.1.x] Add MKS MINI 12864 support to GT2560
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.