[1.1.x] G33 magic numbers #8173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
requested changes
Oct 31, 2017
Marlin/enum.h
Outdated
| __C = _BC + _7P_STEP, | ||
| _CA = __C + _7P_STEP, | ||
| NPP = _7P_STEP * 6 // number of calibration points on the radius | ||
| }; |
There was a problem hiding this comment.
It's not really the proper use of enum. I would recommend doing these as constexpr uint8_t instead.
There was a problem hiding this comment.
As these are only used by G33, they would be better defined just above the G33 function in the .cpp file.
|
doc is changed in #89 to reflect extra probe grids |
thinkyhead
approved these changes
Nov 3, 2017
mtm88001
pushed a commit
to mtm88001/Marlin
that referenced
this pull request
Dec 9, 2017
* [1.1.x] G33 magic numbers * oops * comments * oops * warning * better comment section * remarks * extra grids
damicreabox
pushed a commit
to damicreabox/Marlin
that referenced
this pull request
Sep 14, 2018
* [1.1.x] G33 magic numbers * oops * comments * oops * warning * better comment section * remarks * extra grids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see remarks in #8137